rocketmq
rocketmq copied to clipboard
[ISSUE #8380]fix wrong election in controllerMode
Fixes #8380
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 43.96%. Comparing base (
2bc0014) to head (c87eff0). Report is 2 commits behind head on develop.
| Files | Patch % | Lines |
|---|---|---|
| ...ntroller/impl/manager/RaftReplicasInfoManager.java | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #8383 +/- ##
=============================================
- Coverage 43.99% 43.96% -0.03%
+ Complexity 10670 10667 -3
=============================================
Files 1274 1274
Lines 88939 88938 -1
Branches 11432 11431 -1
=============================================
- Hits 39125 39100 -25
- Misses 44854 44871 +17
- Partials 4960 4967 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your contributions! By the way, how about adding unit tests to cover this code path?
Thanks for your contributions! By the way, how about adding unit tests to cover this code path?
well, i will add unit test
Thanks for your contributions! By the way, how about adding unit tests to cover this code path?
well, i will add unit test
Great! But could u fix these wrong codestyles in your new code for passing the checks.
Thanks for your contributions! By the way, how about adding unit tests to cover this code path?
well, i will add unit test
Great! But could u fix these wrong codestyles in your new code for passing the checks.
done
@RongtongJin @lizhimins Please help review the code,thx
