rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8289] Fixed network bugs and merged networkutil code

Open zekai-li opened this issue 1 year ago • 1 comments
trafficstars

Fix the following three as 1,TraceBean: private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6 2,NetworkUtil:if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."));Check whether Intranet errors exist

Which Issue(s) This PR Fixes

Fixes #8289

Brief Description

How Did You Test This Change?

zekai-li avatar Jun 12 '24 06:06 zekai-li

Codecov Report

Attention: Patch coverage is 58.73016% with 26 lines in your changes missing coverage. Please review.

Project coverage is 42.87%. Comparing base (1a73e01) to head (38be751). Report is 4 commits behind head on develop.

Files Patch % Lines
.../org/apache/rocketmq/common/utils/NetworkUtil.java 58.69% 12 Missing and 7 partials :warning:
.../main/java/org/apache/rocketmq/common/UtilAll.java 58.33% 1 Missing and 4 partials :warning:
...va/org/apache/rocketmq/client/trace/TraceBean.java 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8290      +/-   ##
=============================================
- Coverage      42.90%   42.87%   -0.04%     
+ Complexity     10408    10400       -8     
=============================================
  Files           1274     1274              
  Lines          88952    88966      +14     
  Branches       11438    11443       +5     
=============================================
- Hits           38168    38147      -21     
- Misses         46076    46101      +25     
- Partials        4708     4718      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 12 '24 08:06 codecov-commenter