rocketmq
rocketmq copied to clipboard
[ISSUE #8261]Avoid unnecessary waiting when a response is successfully returned
Which Issue(s) This PR Fixes
Fixes #8261
Brief Description
How Did You Test This Change?
Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
Project coverage is 42.80%. Comparing base (
3ecc73b) to head (4d29bb1).
| Files | Patch % | Lines |
|---|---|---|
| ...mq/client/impl/producer/DefaultMQProducerImpl.java | 0.00% | 3 Missing :warning: |
| ...ocketmq/client/producer/RequestResponseFuture.java | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #8272 +/- ##
=============================================
- Coverage 42.88% 42.80% -0.08%
+ Complexity 10396 10380 -16
=============================================
Files 1274 1274
Lines 88956 88961 +5
Branches 11438 11438
=============================================
- Hits 38151 38083 -68
- Misses 46102 46168 +66
- Partials 4703 4710 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM, but would it be better to add countDown in this piece of code?
public void setSendRequestOk(boolean sendRequestOk) {
this.sendRequestOk = sendRequestOk;
}
countDownLGTM,但是添加代码会更好吗?public void setSendRequestOk(boolean sendRequestOk) { this.sendRequestOk = sendRequestOk; }
But exception callbacks are also used