rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

fix acl magic code when creating acl with empty topicPerms or groupPerms

Open hujie6 opened this issue 1 year ago • 2 comments

Which Issue(s) This PR Fixes

Fixes #8229

Brief Description

How Did You Test This Change?

hujie6 avatar May 31 '24 12:05 hujie6

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.86%. Comparing base (a430796) to head (82f5ef2). Report is 14 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8234      +/-   ##
=============================================
- Coverage      42.96%   42.86%   -0.10%     
- Complexity     10393    10397       +4     
=============================================
  Files           1271     1274       +3     
  Lines          88785    88950     +165     
  Branches       11408    11437      +29     
=============================================
- Hits           38143    38128      -15     
- Misses         45949    46107     +158     
- Partials        4693     4715      +22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 13 '24 02:06 codecov-commenter

this pr has been approved, can it be merged?

hujie6 avatar Jul 24 '24 09:07 hujie6