rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8213] Optimize some code style in remoting module

Open Willhow-Gao opened this issue 1 year ago • 1 comments

Which Issue(s) This PR Fixes

Fixes #8213

Brief Description

How Did You Test This Change?

Willhow-Gao avatar May 27 '24 12:05 Willhow-Gao

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 42.89%. Comparing base (9c8fdb7) to head (b599f44).

Files Patch % Lines
...pache/rocketmq/remoting/common/RemotingHelper.java 13.33% 13 Missing :warning:
...e/rocketmq/remoting/netty/NettyRemotingClient.java 14.28% 6 Missing :warning:
...g/apache/rocketmq/common/filter/impl/Operator.java 0.00% 2 Missing :warning:
...mon/fastjson/GenericMapSuperclassDeserializer.java 0.00% 1 Missing :warning:
...apache/rocketmq/common/filter/impl/PolishExpr.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8214   +/-   ##
==========================================
  Coverage      42.89%   42.89%           
+ Complexity     10369    10366    -3     
==========================================
  Files           1270     1270           
  Lines          88727    88716   -11     
  Branches       11407    11398    -9     
==========================================
- Hits           38061    38057    -4     
+ Misses         45960    45954    -6     
+ Partials        4706     4705    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 27 '24 12:05 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jun 09 '25 00:06 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jun 13 '25 00:06 github-actions[bot]