rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #4685] Avoiding multiple resizing by replacing iterative put with putAll .

Open PansonPanson opened this issue 3 years ago • 2 comments

Avoiding multiple resizing by replacing iterative put with putAll . image

PansonPanson avatar Jul 24 '22 15:07 PansonPanson

Codecov Report

Merging #4684 (d852289) into develop (efbc4a1) will increase coverage by 0.40%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4684      +/-   ##
=============================================
+ Coverage      44.32%   44.72%   +0.40%     
- Complexity      7282     7521     +239     
=============================================
  Files            968      975       +7     
  Lines          65899    67380    +1481     
  Branches        8635     8891     +256     
=============================================
+ Hits           29208    30139     +931     
- Misses         33085    33524     +439     
- Partials        3606     3717     +111     
Impacted Files Coverage Δ
...che/rocketmq/common/protocol/route/BrokerData.java 33.33% <0.00%> (+1.07%) :arrow_up:
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) :arrow_down:
...ava/org/apache/rocketmq/broker/util/HookUtils.java 12.28% <0.00%> (-4.87%) :arrow_down:
...va/org/apache/rocketmq/common/message/Message.java 52.94% <0.00%> (-4.03%) :arrow_down:
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) :arrow_down:
...he/rocketmq/broker/processor/PopReviveService.java 24.90% <0.00%> (-1.81%) :arrow_down:
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) :arrow_down:
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 73.56% <0.00%> (-1.37%) :arrow_down:
...a/org/apache/rocketmq/broker/BrokerController.java 46.10% <0.00%> (-1.16%) :arrow_down:
...a/org/apache/rocketmq/store/StoreStatsService.java 49.72% <0.00%> (-0.56%) :arrow_down:
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Jul 25 '22 03:07 codecov-commenter

Coverage Status

Coverage decreased (-0.02%) to 48.96% when pulling d85228953c6b896c58aa2618b726e32213df80c1 on PansonPanson:develop_20220720 into a6ca01a0f682e0594c7117469f5a9317c3e35d90 on apache:develop.

coveralls avatar Jul 25 '22 03:07 coveralls

Hi,@Oliverwqcwrw @tsunghanjacktsai This code snippet has been carefully profiled and optimized. I'll close this issue. image

PansonPanson avatar Sep 16 '22 06:09 PansonPanson