rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #4634] fix code style in namesrv module

Open PansonPanson opened this issue 3 years ago • 9 comments

PansonPanson avatar Jul 19 '22 14:07 PansonPanson

Hi @PansonPanson ,

Great job. Glad to see more and more developers get to pay attention to our code style. Please checkout CI and fix its errors.

fixed~ in accordance with mq_checkstyle.xml

image

image

  1. white space image

PansonPanson avatar Jul 20 '22 02:07 PansonPanson

Codecov Report

Merging #4635 (876aab2) into develop (244959c) will decrease coverage by 0.19%. The diff coverage is 11.11%.

@@              Coverage Diff              @@
##             develop    #4635      +/-   ##
=============================================
- Coverage      43.30%   43.10%   -0.20%     
+ Complexity      7701     7675      -26     
=============================================
  Files            994      994              
  Lines          68939    68927      -12     
  Branches        9132     9130       -2     
=============================================
- Hits           29853    29711     -142     
- Misses         35341    35481     +140     
+ Partials        3745     3735      -10     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/namesrv/NamesrvStartup.java 16.80% <0.00%> (+0.14%) :arrow_up:
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 64.13% <0.00%> (+3.92%) :arrow_up:
...tmq/namesrv/processor/DefaultRequestProcessor.java 60.00% <0.00%> (ø)
...c/main/java/org/apache/rocketmq/common/MixAll.java 44.23% <40.00%> (-0.36%) :arrow_down:
...a/org/apache/rocketmq/store/StoreStatsService.java 39.22% <0.00%> (-10.50%) :arrow_down:
...apache/rocketmq/store/queue/ConsumeQueueStore.java 53.41% <0.00%> (-5.56%) :arrow_down:
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 77.08% <0.00%> (-4.17%) :arrow_down:
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) :arrow_down:
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 71.11% <0.00%> (-3.82%) :arrow_down:
...a/org/apache/rocketmq/broker/BrokerController.java 43.84% <0.00%> (-3.52%) :arrow_down:
... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 20 '22 04:07 codecov-commenter

Coverage Status

Coverage decreased (-0.02%) to 48.463% when pulling 2fcb3990bfda82c9c4448bd13ee2799eb8bd9aef on PansonPanson:develop into efbc4a1fccd2e79b339ee2e6da7695a03eb31139 on apache:develop.

coveralls avatar Jul 20 '22 04:07 coveralls

Hi @PansonPanson ,

Great job. Glad to see more and more developers get to pay attention to our code style. Please checkout CI and fix its errors.

ci build passed

PansonPanson avatar Jul 21 '22 05:07 PansonPanson

@PansonPanson Hi, could you push an empty commit to trigger the CI again? The CI infra has evolved and it expects new pass results to merge this pull request.

lizhanhui avatar Aug 27 '22 13:08 lizhanhui

@PansonPanson Hi, could you push an empty commit to trigger the CI again? The CI infra has evolved and it expects new pass results to merge this pull request.

lizhanhui avatar Aug 27 '22 13:08 lizhanhui

@lizhanhui I just merged develop into the current branch, but tests failed. Is the remote server healthy? image

PansonPanson avatar Aug 29 '22 02:08 PansonPanson

@PansonPanson Failure of bazel build has been resolved, could you rebase the develop branch again?

aaron-ai avatar Sep 21 '22 13:09 aaron-ai

@aaron-ai create a new PR ,see https://github.com/apache/rocketmq/pull/5159.

PansonPanson avatar Sep 21 '22 14:09 PansonPanson