qpid-proton icon indicating copy to clipboard operation
qpid-proton copied to clipboard

PROTON-2748: Raw connection async close fix and tests.

Open cliffjansen opened this issue 2 years ago • 3 comments
trafficstars

cliffjansen avatar Aug 15 '23 05:08 cliffjansen

@cliffjansen I really like how this has turned out now. Are you finished or are there more changes due to adding new tests?

astitcher avatar Sep 08 '23 21:09 astitcher

I will check in the changes so far to get some extended CI going.

Todo: additional tests as suggested and rename the test. I will leave the pull and JIRA open until they are done and will incorporate additional suggestions.

I propose changing raw_wake_test to raw_connection_proactor_test to reflect it tests the functionality of the proactor implementation of raw connections whereas the existing raw_connection_test tests the proactor-independent bits of the internal/external API without a running proactor.

cliffjansen avatar Sep 11 '23 17:09 cliffjansen

The new commits lgtm

astitcher avatar Sep 22 '23 17:09 astitcher