qpid-proton icon indicating copy to clipboard operation
qpid-proton copied to clipboard

PROTON-2402: Clarify proton docs for on_sendable, prefetch for Messag…

Open NS-SlaFleur opened this issue 4 years ago • 3 comments
trafficstars

…ingHandler, send for Sender and thread-safety for Container.

https://issues.apache.org/jira/browse/PROTON-2402

NS-SlaFleur avatar Jun 25 '21 13:06 NS-SlaFleur

Codecov Report

Merging #324 (5c834cf) into main (a3d1ef4) will increase coverage by 19.68%. The diff coverage is n/a.

:exclamation: Current head 5c834cf differs from pull request most recent head 2a10d7a. Consider uploading reports for the commit 2a10d7a to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##             main     #324       +/-   ##
===========================================
+ Coverage   68.66%   88.34%   +19.68%     
===========================================
  Files         351       47      -304     
  Lines       70321     2394    -67927     
===========================================
- Hits        48285     2115    -46170     
+ Misses      22036      279    -21757     
Impacted Files Coverage Δ
cpp/include/proton/source.hpp
cpp/examples/message_properties.cpp
build/c/src/core/util.c
cpp/src/error.cpp
cpp/include/proton/internal/object.hpp
python/proton/_selectable.py
cpp/src/map.cpp
cpp/include/proton/binary.hpp
c/tests/connection_driver_test.cpp
c/src/handlers/handshaker.c
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3d1ef4...2a10d7a. Read the comment docs.

codecov-commenter avatar Jun 25 '21 16:06 codecov-commenter

@NS-MNellen will take over this PR if there are any questions.

NS-SlaFleur avatar Jul 30 '21 14:07 NS-SlaFleur

@ssorj Could you look at these doc changes and see if you think this is an improvement.

astitcher avatar Apr 11 '23 18:04 astitcher