pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[feat][broker] PIP-264: Add OpenTelemetry managed ledger metrics

Open dragosvictor opened this issue 1 year ago • 1 comments

PIP-264

Motivation

Adds Managed Ledger metrics, as currently described here, to the OpenTelemetry pipeline.

Modifications

  • Adds the metrics described in https://github.com/apache/pulsar-site/pull/930 to the collector runs.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

This change modified tests and can be verified as follows:

  • Updated test ManagedLedgerMetricsTest#testManagedLedgerMetrics to cover the OpenTelemetry metrics

Does this pull request potentially affect one of the following parts:

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [x] The metrics: As described in https://github.com/apache/pulsar-site/pull/930
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [x] doc-required https://github.com/apache/pulsar-site/pull/930
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/dragosvictor/pulsar/pull/35

dragosvictor avatar Jun 27 '24 18:06 dragosvictor

Codecov Report

Attention: Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (bbc6224) to head (97db472). Report is 427 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22987      +/-   ##
============================================
- Coverage     73.57%   73.45%   -0.12%     
- Complexity    32624    33287     +663     
============================================
  Files          1877     1909      +32     
  Lines        139502   143054    +3552     
  Branches      15299    15578     +279     
============================================
+ Hits         102638   105080    +2442     
- Misses        28908    29943    +1035     
- Partials       7956     8031      +75     
Flag Coverage Δ
inttests 27.74% <98.03%> (+3.16%) :arrow_up:
systests 24.75% <47.05%> (+0.42%) :arrow_up:
unittests 72.47% <98.03%> (-0.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...he/bookkeeper/mledger/ManagedLedgerAttributes.java 100.00% <100.00%> (ø)
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 82.03% <100.00%> (+0.64%) :arrow_up:
...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java 90.34% <100.00%> (+0.63%) :arrow_up:
.../mledger/impl/OpenTelemetryManagedLedgerStats.java 100.00% <100.00%> (ø)
.../pulsar/opentelemetry/OpenTelemetryAttributes.java 100.00% <100.00%> (ø)
...a/org/apache/bookkeeper/mledger/ManagedLedger.java 0.00% <0.00%> (ø)
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 81.33% <80.00%> (+0.67%) :arrow_up:

... and 476 files with indirect coverage changes

codecov-commenter avatar Jun 28 '24 12:06 codecov-commenter