pulsar
pulsar copied to clipboard
[feat][broker][PIP-195] Implement BucketDelayedDeliveryTrackerFactory and load BucketDelayedDeliveryTracker - part5
Master Issue: #16763
Motivation
#16763
Modifications
- Implement BucketDelayedDeliveryTrackerFactory.
- Change DeliveryTrackerFactory interface to adapter BucketDelayedDeliveryTrackerFactory.
- Load BucketDelayedDeliveryTracker.
Verifying this change
- [x] Make sure that the change passes the CI checks.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added integration tests for end-to-end deployment with large payloads (10MB)
- Extended integration test for recovery after broker failure
Documentation
-
[ ]
doc-required(Your PR needs to update docs and you will update later) -
[x]
doc-not-needed(Please explain why) -
[ ]
doc(Your PR contains doc changes) -
[ ]
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: xxx
Depend on #17611 and #17677
The pr had no activity for 30 days, mark with Stale label.
The test failed and wait for #19124 merged.
Codecov Report
Merging #17756 (6776c49) into master (9ec1d07) will decrease coverage by
0.57%. The diff coverage is32.07%.
@@ Coverage Diff @@
## master #17756 +/- ##
============================================
- Coverage 47.73% 47.15% -0.58%
+ Complexity 10819 10695 -124
============================================
Files 712 713 +1
Lines 69645 69672 +27
Branches 7481 7482 +1
============================================
- Hits 33242 32857 -385
- Misses 32699 33100 +401
- Partials 3704 3715 +11
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 47.15% <32.07%> (-0.58%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 53.76% <0.00%> (-0.07%) |
:arrow_down: |
| .../pulsar/broker/admin/impl/SchemasResourceBase.java | 89.21% <0.00%> (-0.89%) |
:arrow_down: |
| ...r/delayed/BucketDelayedDeliveryTrackerFactory.java | 0.00% <0.00%> (ø) |
|
| ...apache/pulsar/broker/admin/v1/SchemasResource.java | 26.50% <10.00%> (ø) |
|
| ...apache/pulsar/broker/admin/v2/SchemasResource.java | 72.28% <40.00%> (ø) |
|
| ...rg/apache/pulsar/broker/service/BrokerService.java | 57.28% <50.00%> (-0.11%) |
:arrow_down: |
| .../org/apache/pulsar/broker/admin/AdminResource.java | 65.06% <75.00%> (-1.53%) |
:arrow_down: |
| ...r/broker/delayed/DelayedDeliveryTrackerLoader.java | 66.66% <100.00%> (+4.16%) |
:arrow_up: |
| ...delayed/InMemoryDelayedDeliveryTrackerFactory.java | 91.66% <100.00%> (+0.75%) |
:arrow_up: |
| ...sar/broker/service/persistent/PersistentTopic.java | 61.49% <100.00%> (-1.19%) |
:arrow_down: |
| ... and 50 more |
This PR introduced a flaky test, #19902 . @coderzc Do you have a chance to fix it? Thanks