[feat][broker][PIP-195] Support internal cursor properties - part4

[coderzc]

trafficstars

Master Issue: #16763

Motivation

Now, the cursor properties support overall update and modifying a single value concurrently by #17164, but setCursorProperties will all key-value is removed before update properties, this will cause internal property loss, so use a special prefix to prevent internal properties.

More context see: https://github.com/apache/pulsar/pull/17164#issuecomment-1236872277, https://github.com/apache/pulsar/pull/17164#issuecomment-1241523618, https://github.com/apache/pulsar/pull/17164#issuecomment-1241536546

Modifications

Use a special prefix to prevent internal properties.

Verifying this change

• [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Documentation

• [ ] doc-required (Your PR needs to update docs and you will update later)

• [x] doc-not-needed (Please explain why)

• [ ] doc (Your PR contains doc changes)

• [ ] doc-complete (Docs have been already added)

Matching PR in forked repository PR in forked repository: https://github.com/coderzc/pulsar/pull/4

[lhotari]

the tests failed in Broker Group 3 because of OOM, I filed #17714 . It's most likely not caused by the changes in this PR.

[github-actions[bot]]

The pr had no activity for 30 days, mark with Stale label.

[coderzc]

@lhotari @eolivelli @Jason918 @codelipenghui @mattisonchao PTAL

[codecov-commenter]

Codecov Report

Merging #17712 (f01a4d4) into master (a2c1534) will increase coverage by 0.68%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #17712      +/-   ##
============================================
+ Coverage     47.23%   47.91%   +0.68%     
+ Complexity    10430     9349    -1081     
============================================
  Files           692      613      -79     
  Lines         67766    58391    -9375     
  Branches       7260     6087    -1173     
============================================
- Hits          32009    27978    -4031     
+ Misses        32192    27379    -4813     
+ Partials       3565     3034     -531     

Flag	Coverage Δ
unittests	47.91% <100.00%> (+0.68%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ava/org/apache/pulsar/broker/service/Consumer.java	69.57% <100.00%> (-2.60%)	:arrow_down:
...apache/pulsar/client/impl/AutoClusterFailover.java	70.00% <0.00%> (-6.12%)	:arrow_down:
...oker/service/schema/SchemaRegistryServiceImpl.java	59.45% <0.00%> (-5.41%)	:arrow_down:
...ction/buffer/impl/TransactionBufferClientImpl.java	76.74% <0.00%> (-4.66%)	:arrow_down:
.../buffer/impl/TransactionBufferClientStatsImpl.java	82.00% <0.00%> (-4.00%)	:arrow_down:
...pulsar/broker/TransactionMetadataStoreService.java	58.51% <0.00%> (-3.94%)	:arrow_down:
...tion/buffer/impl/TransactionBufferHandlerImpl.java	50.00% <0.00%> (-2.54%)	:arrow_down:
...tent/PersistentDispatcherSingleActiveConsumer.java	54.85% <0.00%> (-1.89%)	:arrow_down:
...ervice/AbstractDispatcherSingleActiveConsumer.java	69.15% <0.00%> (-1.87%)	:arrow_down:
... and 100 more

[coderzc]

@lhotari @eolivelli @Jason918 @codelipenghui PTAL