pulsar
pulsar copied to clipboard
[feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2
Master Issue: #16763
Motivation
#16763
Modifications
- Implement delayed message index bucket
- Implement delayed message index bucket snapshot (create/load)
- Reuse and refactor InMemoryDelayedDeliveryTracker
- Reuse and refactor InMemoryDeliveryTrackerTest
- Add test for BuketDelayedDeliveryTracker
Documentation
-
[ ]
doc-required(Your PR needs to update docs and you will update later) -
[x]
doc-not-needed(Please explain why) -
[ ]
doc(Your PR contains doc changes) -
[ ]
doc-complete(Docs have been already added)
Matching PR in forked repository PR in forked repository: https://github.com/coderzc/pulsar/pull/2
Dependent on #17344 and #17164
@codelipenghui @gaoran10 @Technoboy- PTAL
I will review it again tomorrow(test & logic), thanks for your great work!
Codecov Report
Merging #17611 (8405d13) into master (67d9d63) will increase coverage by
4.18%. The diff coverage is9.63%.
@@ Coverage Diff @@
## master #17611 +/- ##
============================================
+ Coverage 40.29% 44.48% +4.18%
- Complexity 8685 10482 +1797
============================================
Files 687 752 +65
Lines 67441 72530 +5089
Branches 7225 7792 +567
============================================
+ Hits 27175 32263 +5088
+ Misses 37257 36591 -666
- Partials 3009 3676 +667
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 44.48% <9.63%> (+4.18%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...che/bookkeeper/mledger/impl/ManagedCursorImpl.java | 36.81% <0.00%> (-0.09%) |
:arrow_down: |
| ...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java | 65.55% <ø> (+0.72%) |
:arrow_up: |
| ...va/org/apache/bookkeeper/mledger/util/Futures.java | 55.88% <0.00%> (ø) |
|
| ...rg/apache/pulsar/broker/delayed/bucket/Bucket.java | 0.00% <0.00%> (ø) |
|
| ...r/delayed/bucket/BucketDelayedDeliveryTracker.java | 0.00% <0.00%> (ø) |
|
| .../pulsar/broker/delayed/bucket/ImmutableBucket.java | 0.00% <0.00%> (ø) |
|
| ...he/pulsar/broker/delayed/bucket/MutableBucket.java | 0.00% <0.00%> (ø) |
|
| ...sistent/PersistentDispatcherMultipleConsumers.java | 51.15% <0.00%> (-7.19%) |
:arrow_down: |
| ...broker/delayed/AbstractDelayedDeliveryTracker.java | 62.74% <62.74%> (ø) |
|
| ...broker/delayed/InMemoryDelayedDeliveryTracker.java | 68.33% <71.42%> (+3.33%) |
:arrow_up: |
| ... and 283 more |
/pulsarbot run-failure-checks