pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][broker] Filter out already delete entry again before send message to consumer

Open coderzc opened this issue 3 years ago • 0 comments
trafficstars

Fixes #16949

Motivation

Now, sending messages to the consumer using io-thread. When the task is scheduled, the message ack may be already changed leading to delivering the message of already been acknowledged.

Modifications

Filter out already delete entries again before sending message to the consumer.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

coderzc avatar Aug 10 '22 04:08 coderzc

/pulsarbot run-failure-checks

coderzc avatar Aug 10 '22 10:08 coderzc

@coderzc Please rebase to the master branch.

codelipenghui avatar Aug 10 '22 16:08 codelipenghui

/pulsarbot run-failure-checks

coderzc avatar Aug 12 '22 03:08 coderzc

@codelipenghui PTAL

coderzc avatar Aug 12 '22 11:08 coderzc