plc4x icon indicating copy to clipboard operation
plc4x copied to clipboard

Add more tests for mspec parser and code generator.

Open splatch opened this issue 1 year ago • 10 comments

splatch avatar Aug 23 '24 13:08 splatch

as of a668321 this doesnt even build on java :/

sruehl avatar Aug 24 '24 06:08 sruehl

ok I think I was on the wrong revision e5d1782... nvm

sruehl avatar Aug 24 '24 06:08 sruehl

@splatch please rebase on current main

sruehl avatar Aug 24 '24 07:08 sruehl

@splatch careful that you leave it as readAManual field otherwise we have lang collisions in Goland

sruehl avatar Sep 18 '24 06:09 sruehl

also it seems you reverted stuff by accident with the rebase, not sure why dad got deleted :D

sruehl avatar Sep 18 '24 06:09 sruehl

as a small background why I used non-technical terms: When you debug that stuff and you stumble over structs named struct it is getting pretty confusing. So the goal there was to avoid to use the codegen terms so it is easier to seperate content from codegen items.

sruehl avatar Sep 18 '24 06:09 sruehl

I was sure that this A was a typo! I will try to pull back commit from reflog and cherry pick it on top of develop.

splatch avatar Sep 18 '24 08:09 splatch

no worries, just from the looks of it it looks like a failed rebase/merge :) Afaik this should be the only change in that PR image

sruehl avatar Sep 18 '24 11:09 sruehl

maybe the other one above but not sure. Think I got rid of it because of the confusion image but if you added that feel free to readd

sruehl avatar Sep 18 '24 12:09 sruehl

@sruehl I've cherry picked only intended changes, should be better now.

splatch avatar Sep 24 '24 16:09 splatch