plc4x icon indicating copy to clipboard operation
plc4x copied to clipboard

fix: added timeouts for reading data/getting connection

Open geneross opened this issue 1 year ago • 2 comments

geneross avatar Jan 24 '24 08:01 geneross

LGTM

chrisdutz avatar Feb 12 '24 15:02 chrisdutz

However a bit more explanations on what a PR is about would have been nice ;-)

chrisdutz avatar Feb 12 '24 15:02 chrisdutz

Thanks for paying attention. I was desperate to get an answer. Lost in permissions etc. In general we've faced with case when TriggeredScraperImpl threads just silently dies partially because of network malfunction partially because of server bugs. So TriggeredScraperImpl got 2 debug threads that watch on working threads and it static get connection method now re-throw unchecked PlcRuntimeException because otherwise it might re-throw checked exception that leads to working thread termination. Second. PlcReadRequest.builder from LeasedPlcConnection now return class with execution timeout for innerPlcReadRequest. Third. ConnectionContainer set container value to null when it can't get connection from the manager while trying to invalidate cached connection. Otherwise it created new LeasedConnection with same broken connection.

My apologies for brevity, I have to recall what I did 2 month ago. ))

geneross avatar Mar 05 '24 11:03 geneross