pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Auto reset of error segments on segment validation

Open shauryachats opened this issue 1 year ago • 1 comments

Auto reset of error segments can be done whenever segment validation flow executes, which eliminates the need for manual resolution.

This feature is gated behind the controller config controller.segment.error.autoReset which is set to false by default.

shauryachats avatar Oct 14 '24 02:10 shauryachats

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.71%. Comparing base (59551e4) to head (6e0175e). Report is 1630 commits behind head on master.

Files with missing lines Patch % Lines
...ller/validation/OfflineSegmentIntervalChecker.java 33.33% 2 Missing :warning:
...r/validation/RealtimeSegmentValidationManager.java 33.33% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14217      +/-   ##
============================================
+ Coverage     61.75%   63.71%   +1.96%     
- Complexity      207     1471    +1264     
============================================
  Files          2436     2708     +272     
  Lines        133233   151555   +18322     
  Branches      20636    23402    +2766     
============================================
+ Hits          82274    96570   +14296     
- Misses        44911    47733    +2822     
- Partials       6048     7252    +1204     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) :arrow_up:
integration 100.00% <ø> (+99.99%) :arrow_up:
integration1 100.00% <ø> (+99.99%) :arrow_up:
integration2 0.00% <ø> (ø)
java-11 63.69% <42.85%> (+1.98%) :arrow_up:
java-21 63.61% <42.85%> (+1.98%) :arrow_up:
skip-bytebuffers-false 63.71% <42.85%> (+1.96%) :arrow_up:
skip-bytebuffers-true 63.59% <42.85%> (+35.86%) :arrow_up:
temurin 63.71% <42.85%> (+1.96%) :arrow_up:
unittests 63.71% <42.85%> (+1.96%) :arrow_up:
unittests1 56.27% <ø> (+9.38%) :arrow_up:
unittests2 34.02% <42.85%> (+6.29%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 14 '24 03:10 codecov-commenter

Any reason to keep it behind a flag? Any issue with always resetting error segments by default? @shauryachats

noob-se7en avatar Apr 29 '25 17:04 noob-se7en