Add Tabled Is Disabled Error

[ashishjayamohan]

• Closes #14087
• Checks if table is disabled
• If table is disabled, then sends an error specifying that the table is disabled when queried

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (a82ce3e). Report is 1232 commits behind head on master.

Files with missing lines	Patch %	Lines
...sthandler/BaseSingleStageBrokerRequestHandler.java	28.57%	13 Missing and 2 partials :warning:
...che/pinot/broker/routing/BrokerRoutingManager.java	22.22%	5 Missing and 2 partials :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #14199      +/-   ##
============================================
+ Coverage     61.75%   63.81%   +2.06%     
- Complexity      207     1535    +1328     
============================================
  Files          2436     2628     +192     
  Lines        133233   144917   +11684     
  Branches      20636    22172    +1536     
============================================
+ Hits          82274    92477   +10203     
- Misses        44911    45601     +690     
- Partials       6048     6839     +791     

Flag	Coverage Δ
custom-integration1	100.00% <ø> (+99.99%)	:arrow_up:
integration	100.00% <ø> (+99.99%)	:arrow_up:
integration1	100.00% <ø> (+99.99%)	:arrow_up:
integration2	0.00% <ø> (ø)
java-11	63.77% <33.33%> (+2.06%)	:arrow_up:
java-21	63.70% <33.33%> (+2.07%)	:arrow_up:
skip-bytebuffers-false	63.79% <33.33%> (+2.04%)	:arrow_up:
skip-bytebuffers-true	63.67% <33.33%> (+35.94%)	:arrow_up:
temurin	63.81% <33.33%> (+2.06%)	:arrow_up:
unittests	63.80% <33.33%> (+2.06%)	:arrow_up:
unittests1	55.37% <100.00%> (+8.48%)	:arrow_up:
unittests2	34.35% <33.33%> (+6.61%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ashishjayamohan]

@yashmayya RE: https://github.com/apache/pinot/pull/14154#discussion_r1793144576 Ended up making those changes. Before I go in and debug the failing tests, does my approach look correct so far?

[ashishjayamohan]

@Jackie-Jiang @yashmayya Finished making those changes. Let me know if anything looks off.

[vrajat]

Is the tar.gz file added by mistake ?

[ashishjayamohan]

I'm unsure of what that file is to be entirely honest. I didn't manually add it in, but I imagine it must've been added as part of some test? Removing it now since it seems to be unnecessary.

[ashishjayamohan]

@Jackie-Jiang I changed the behavior here. In the case where the user is querying a hybrid table and one table (offline/realtime) is disabled, it will add a partial results error message stating that. In the case where there is only one table and that table is disabled, this will simply return an exception. I also made the relevant changes to make this a thread-safe operation (as opposed to the set).

[ashishjayamohan]

Made those requested changes. Let me know what you think!

[ashishjayamohan]

Fixed!