pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Upgrade http5 Client to 5.4 and using Http 2 Protocol

Open abhioncbr opened this issue 1 year ago • 6 comments

As per the issue, In this PR we are upgrading the httpclient5 from 5.3.1 to 5.4.

Details

  • We observed test failures in the Dependabot PR because of the default connection reuse strategy. In httpclient5 version 5.4-alpha2, team fixed the issue, and because of this, we started seeing the failures with the error log
Connection error . Details: org.apache.hc.core5.http.NoHttpResponseException: localhost:22000 failed to respond
10:03:41.417 ERROR [CompletionServiceHelper] [grizzly-http-server-16] Connection error . Details: org.apache.hc.core5.http.NoHttpResponseException: localhost:22000 failed to respond

~~To fix this issue, In this PR we are setting the ConnectionReuseStrategy to false to resolve all the errors.~~

On further investigation, I am unable to determine whether the failures are purely due to the above-mentioned issue or to changes in caching with connections. I need help from someone to pin down the exact reason.

While investigating, I noticed that using the HTTP 2 protocol instead of HTTP 1.1 resulted in no issues in our entire test suite. Can we accept this as a solution?

abhioncbr avatar Oct 09 '24 02:10 abhioncbr