pinot icon indicating copy to clipboard operation
pinot copied to clipboard

supporting additional headers

Open hdulay opened this issue 1 year ago • 3 comments

See #13416 and #13419

hdulay avatar Jun 17 '24 21:06 hdulay

@Jackie-Jiang Hi. Can you review please? Thanks

hdulay avatar Jun 18 '24 23:06 hdulay

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.95%. Comparing base (59551e4) to head (3be71f0). Report is 862 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13417      +/-   ##
============================================
+ Coverage     61.75%   61.95%   +0.20%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2557     +121     
  Lines        133233   141092    +7859     
  Branches      20636    21943    +1307     
============================================
+ Hits          82274    87412    +5138     
- Misses        44911    47029    +2118     
- Partials       6048     6651     +603     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) :arrow_down:
integration <0.01% <ø> (-0.01%) :arrow_down:
integration1 <0.01% <ø> (-0.01%) :arrow_down:
integration2 0.00% <ø> (ø)
java-11 61.91% <ø> (+0.20%) :arrow_up:
java-21 61.84% <ø> (+0.21%) :arrow_up:
skip-bytebuffers-false 61.93% <ø> (+0.18%) :arrow_up:
skip-bytebuffers-true 61.82% <ø> (+34.09%) :arrow_up:
temurin 61.95% <ø> (+0.20%) :arrow_up:
unittests 61.94% <ø> (+0.20%) :arrow_up:
unittests1 46.39% <ø> (-0.50%) :arrow_down:
unittests2 27.80% <ø> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 24 '24 18:06 codecov-commenter

Changing from -headers to -database @Jackie-Jiang @npawar

hdulay avatar Jun 27 '24 21:06 hdulay