pinot icon indicating copy to clipboard operation
pinot copied to clipboard

UI Load time Improvement API Fixes #13278

Open deepthi912 opened this issue 1 year ago • 1 comments

https://github.com/apache/pinot/issues/13278 https://docs.google.com/document/d/1rsDF6Ky4dZAtblPUIQXh8bQDkVMYbF4sU2Hci--7K-U/edit?pli=1

This PR has all API changes to improve UI load times and 2 UI fixes integrated with the APIs. UI changes of the below points yet to be addressed to validate overall load time improvement.

Peding and upcoming Fix:

  1. /instances and /LIVEINSTANCES usage is not reduced to (8 times, 4 times) to 1 yet on UI side.
  2. Table Status and Segment statuses (already added) to be linked with UI to remove dependency on below end points.
  • /tables/{tableName}/idealstate
  • /tables/{tableName}/externalview

deepthi912 avatar Jun 02 '24 23:06 deepthi912

Codecov Report

Attention: Patch coverage is 40.00000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 57.56%. Comparing base (59551e4) to head (b16c244). Report is 957 commits behind head on master.

Files with missing lines Patch % Lines
...ller/api/resources/PinotSchemaRestletResource.java 0.00% 15 Missing :warning:
...ler/api/resources/PinotSegmentRestletResource.java 0.00% 14 Missing :warning:
...che/pinot/controller/api/resources/TableViews.java 62.85% 11 Missing and 2 partials :warning:
...ntroller/helix/core/PinotHelixResourceManager.java 0.00% 11 Missing :warning:
...ache/pinot/controller/api/resources/TableSize.java 0.00% 4 Missing and 1 partial :warning:
...roller/api/resources/PinotTaskRestletResource.java 0.00% 1 Missing :warning:
...va/org/apache/pinot/spi/utils/CommonConstants.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13296      +/-   ##
============================================
- Coverage     61.75%   57.56%   -4.19%     
+ Complexity      207      197      -10     
============================================
  Files          2436     2586     +150     
  Lines        133233   142724    +9491     
  Branches      20636    22149    +1513     
============================================
- Hits          82274    82158     -116     
- Misses        44911    54064    +9153     
- Partials       6048     6502     +454     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration <0.01% <0.00%> (-0.01%) :arrow_down:
integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration2 0.00% <0.00%> (ø)
java-11 57.51% <40.00%> (-4.20%) :arrow_down:
java-21 57.45% <40.00%> (-4.18%) :arrow_down:
skip-bytebuffers-false 57.55% <40.00%> (-4.20%) :arrow_down:
skip-bytebuffers-true 57.42% <40.00%> (+29.69%) :arrow_up:
temurin 57.56% <40.00%> (-4.19%) :arrow_down:
unittests 57.56% <40.00%> (-4.19%) :arrow_down:
unittests1 40.22% <92.30%> (-6.67%) :arrow_down:
unittests2 27.88% <28.00%> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 03 '24 02:06 codecov-commenter