pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Fix the time segment pruner on TIMESTAMP data type

Open Jackie-Jiang opened this issue 1 year ago • 1 comments

Fix #12721

When data type is TIMESTAMP, fix the format to be "TIMESTAMP" because the time format is already implicit from the data type.

Jackie-Jiang avatar Apr 04 '24 00:04 Jackie-Jiang

Codecov Report

Attention: Patch coverage is 66.66667% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 62.00%. Comparing base (59551e4) to head (fecfb79). Report is 212 commits behind head on master.

Files Patch % Lines
...roker/routing/segmentpruner/TimeSegmentPruner.java 47.05% 9 Missing and 9 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12789      +/-   ##
============================================
+ Coverage     61.75%   62.00%   +0.25%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2462      +26     
  Lines        133233   134797    +1564     
  Branches      20636    20831     +195     
============================================
+ Hits          82274    83584    +1310     
- Misses        44911    45066     +155     
- Partials       6048     6147      +99     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration <0.01% <0.00%> (-0.01%) :arrow_down:
integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration2 0.00% <0.00%> (ø)
java-11 61.96% <66.66%> (+0.25%) :arrow_up:
java-21 61.88% <66.66%> (+0.26%) :arrow_up:
skip-bytebuffers-false 61.98% <66.66%> (+0.23%) :arrow_up:
skip-bytebuffers-true 61.86% <66.66%> (+34.14%) :arrow_up:
temurin 62.00% <66.66%> (+0.25%) :arrow_up:
unittests 62.00% <66.66%> (+0.25%) :arrow_up:
unittests1 46.71% <100.00%> (-0.18%) :arrow_down:
unittests2 28.00% <51.85%> (+0.27%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 04 '24 01:04 codecov-commenter