pinot
pinot copied to clipboard
[null support] Allow fill the derived column with null when transform function failed to execute
Allow fill the derived column with null when transform function failed to execute
Codecov Report
Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.
Project coverage is 62.23%. Comparing base (
59551e4) to head (801d261). Report is 2626 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...loader/defaultcolumn/BaseDefaultColumnHandler.java | 62.85% | 11 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #12763 +/- ##
============================================
+ Coverage 61.75% 62.23% +0.47%
+ Complexity 207 198 -9
============================================
Files 2436 2531 +95
Lines 133233 138560 +5327
Branches 20636 21448 +812
============================================
+ Hits 82274 86228 +3954
- Misses 44911 45884 +973
- Partials 6048 6448 +400
| Flag | Coverage Δ | |
|---|---|---|
| custom-integration1 | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration1 | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration2 | 0.00% <0.00%> (ø) |
|
| java-11 | 62.20% <62.85%> (+0.49%) |
:arrow_up: |
| java-21 | 62.11% <62.85%> (+0.49%) |
:arrow_up: |
| skip-bytebuffers-false | 62.22% <62.85%> (+0.47%) |
:arrow_up: |
| skip-bytebuffers-true | 62.09% <62.85%> (+34.36%) |
:arrow_up: |
| temurin | 62.23% <62.85%> (+0.47%) |
:arrow_up: |
| unittests | 62.22% <62.85%> (+0.47%) |
:arrow_up: |
| unittests1 | 46.67% <0.00%> (-0.22%) |
:arrow_down: |
| unittests2 | 27.92% <62.85%> (+0.19%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Can you add a test for this? I think current code will NPE because it doesn't handle
nulloutput value. It doesn't generate null vector as well
Added a test for wrong arguments transform function.
Covered by #13212