pinot
pinot copied to clipboard
fix for #12735. moving dependency version declarations to maven properties
this PR fixes #12735 by moving dependency version declarations in the main pom to properties. This makes the approach to dependency management a bit more consistent and sets the basis for future dependency rework as mentioned in #12676 a bit easier to get going
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.50%. Comparing base (
59551e4) to head (98318e7). Report is 179 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #12736 +/- ##
============================================
- Coverage 61.75% 61.50% -0.25%
+ Complexity 207 198 -9
============================================
Files 2436 2460 +24
Lines 133233 134612 +1379
Branches 20636 20841 +205
============================================
+ Hits 82274 82793 +519
- Misses 44911 45631 +720
- Partials 6048 6188 +140
| Flag | Coverage Δ | |
|---|---|---|
| custom-integration1 | <0.01% <ø> (-0.01%) |
:arrow_down: |
| integration | <0.01% <ø> (-0.01%) |
:arrow_down: |
| integration1 | <0.01% <ø> (-0.01%) |
:arrow_down: |
| integration2 | 0.00% <ø> (ø) |
|
| java-11 | 34.46% <ø> (-27.25%) |
:arrow_down: |
| java-21 | 61.39% <ø> (-0.24%) |
:arrow_down: |
| skip-bytebuffers-false | 61.47% <ø> (-0.27%) |
:arrow_down: |
| skip-bytebuffers-true | 61.35% <ø> (+33.63%) |
:arrow_up: |
| temurin | 61.50% <ø> (-0.25%) |
:arrow_down: |
| unittests | 61.50% <ø> (-0.25%) |
:arrow_down: |
| unittests1 | 46.09% <ø> (-0.80%) |
:arrow_down: |
| unittests2 | 27.93% <ø> (+0.20%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We are merging https://github.com/apache/pinot/pull/15437
This can be closed
cc @leujean02 @gviedma