pinot
pinot copied to clipboard
Add more validations for upserts
- Do not allow users to change primary key columns
- Check if snapshot is enabled already if preload is enabled
Codecov Report
Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
Project coverage is 62.01%. Comparing base (
59551e4) to head (119bc06). Report is 1778 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #12686 +/- ##
============================================
+ Coverage 61.75% 62.01% +0.26%
+ Complexity 207 198 -9
============================================
Files 2436 2461 +25
Lines 133233 134745 +1512
Branches 20636 20822 +186
============================================
+ Hits 82274 83566 +1292
- Misses 44911 45033 +122
- Partials 6048 6146 +98
| Flag | Coverage Δ | |
|---|---|---|
| custom-integration1 | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration1 | <0.01% <0.00%> (-0.01%) |
:arrow_down: |
| integration2 | 0.00% <0.00%> (ø) |
|
| java-11 | 61.97% <37.50%> (+0.26%) |
:arrow_up: |
| java-21 | 61.86% <37.50%> (+0.24%) |
:arrow_up: |
| skip-bytebuffers-false | 62.00% <37.50%> (+0.26%) |
:arrow_up: |
| skip-bytebuffers-true | 61.82% <37.50%> (+34.10%) |
:arrow_up: |
| temurin | 62.01% <37.50%> (+0.26%) |
:arrow_up: |
| unittests | 62.01% <37.50%> (+0.26%) |
:arrow_up: |
| unittests1 | 46.74% <25.00%> (-0.15%) |
:arrow_down: |
| unittests2 | 27.98% <12.50%> (+0.25%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Not sure if we want to prevent user from changing primary keys. If there is no snapshot, changing primary key should be okay