nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-10652 Correct dependency scopes for nifi-iceberg-processors

Open exceptionfactory opened this issue 3 years ago • 2 comments
trafficstars

Summary

NIFI-10652 Corrects dependency scoping for nifi-iceberg-processors and nifi-iceberg-processors-nar to avoid unnecessary duplication of dependencies available in nifi-iceberg-services-api-nar. The changes reduce the size of nifi-iceberg-processors-nar from over 110 MB to around 20 MB.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [X] Pull Request based on current revision of the main branch
  • [X] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [X] Build completed using mvn clean install -P contrib-check
    • [X] JDK 8
    • [ ] JDK 11
    • [ ] JDK 17

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

exceptionfactory avatar Oct 14 '22 16:10 exceptionfactory

Hi @exceptionfactory, thanks for checking the dependency scope correctness. I've tested the processor and it works properly with your changes. PR looks good to me.

mark-bathori avatar Oct 18 '22 08:10 mark-bathori

Thanks for the review and testing @mark-bathori!

exceptionfactory avatar Oct 18 '22 13:10 exceptionfactory

+1 LGTM, thanks for the improvments and review! Merging to main

mattyb149 avatar Oct 18 '22 17:10 mattyb149