mynewt-nimble
mynewt-nimble copied to clipboard
apache
nimble/host: Add support to accept or reject pairing request through GAP event
- The PR is intended to give chance to application to accept or reject pairing request through GAP event.
- In case of implementing Mode 1 security level 4, the connection should be
authenticated le secure connection only, but there is no way to make sure that theMode 1 security level 4is achieved or not. The PR addresses this issue in particular but is not limited to.
@rymanluk Apologies for not updating the PR for long time. I have incorporated your suggestions. Please take a look and suggest if any improvements. I am expecting few CI test failures given the nature of PR, please provide inputs on modifying tests as well. Thanks
@prasad-alatkar looks like unit tests are failing. newt test @apache-mynewt-nimble/nimble/host/test could you check that? Also could you please add a patch to btshell which would allow to test this patch? Thanks
@prasad-alatkar looks like unit tests are failing. newt test @apache-mynewt-nimble/nimble/host/test could you check that? Also could you please add a patch to btshell which would allow to test this patch? Thanks
@rymanluk , as per my understanding the failure is seen in unit test : ble_sm_test_case_peer_lgcy_fail_confirm. However, I am a little confused with the error prints here: nimble_host_test.elf: nimble/host/src/ble_hs.c:194: ble_hs_lock: Assertion !ble_hs_locked_by_cur_task()' failed. It seems that ble_hs_lock` is getting called twice somewhere, but the PR changes do not add any extra host lock. Could you please help here to pass the CI tests ? I am not very familiar with BT tests here, could you please let me know if it is possible to collect debug logs through CI ?
Hi @rymanluk , Can you kindly let us know that except for the test case passing, is the code changes done to resolve this issue acceptable ?
Thanks, Rahul
