mynewt-nimble icon indicating copy to clipboard operation
mynewt-nimble copied to clipboard

host/ble_gap.c : Check allowed random address

Open rahult-github opened this issue 2 years ago • 6 comments

Add a check to validate whether the random address being set is allowed as per spec

rahult-github avatar Sep 15 '23 02:09 rahult-github

Hi @sjanc , can you please review this change.

rahult-github avatar Oct 10 '23 05:10 rahult-github

I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses. There are similar checks for static random when calling ble_hs_id_set_rnd() etc

sjanc avatar Oct 10 '23 06:10 sjanc

I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses. There are similar checks for static random when calling ble_hs_id_set_rnd() etc

Thanks for the review . I have made a generic function to check if passed address is as per spec or not.

rahult-github avatar Oct 13 '23 10:10 rahult-github

@sjanc , Please let me know if you have any more suggestions / comments.

rahult-github avatar Oct 23 '23 03:10 rahult-github

@sjanc ping

rymanluk avatar Mar 25 '24 07:03 rymanluk

Hi @sjanc , please take a look

rahult-github avatar May 06 '24 10:05 rahult-github