mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

Add support for bool data type for condition in where operator

Open bgawrych opened this issue 3 years ago • 5 comments

Description

This change allows to utilize bool data type for condition tensor in oneDNN implementation of where operator

Checklist

Essentials

  • [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [ ] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage
  • [ ] Code is well-documented

Changes

  • [ ] Feature1, tests, (and when applicable, API doc)
  • [ ] Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

bgawrych avatar Jul 20 '22 12:07 bgawrych

Hey @bgawrych , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, website, sanity, centos-gpu, unix-gpu, clang, miscellaneous, windows-cpu, windows-gpu, unix-cpu, centos-cpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Jul 20 '22 12:07 mxnet-bot

@mxnet-bot run ci [centos-cpu, unix-cpu, unix-gpu]

bgawrych avatar Aug 01 '22 06:08 bgawrych

Jenkins CI successfully triggered : [centos-cpu, unix-cpu, unix-gpu]

mxnet-bot avatar Aug 01 '22 06:08 mxnet-bot

@mxnet-bot run ci [centos-gpu]

bgawrych avatar Aug 09 '22 07:08 bgawrych

Jenkins CI successfully triggered : [centos-gpu]

mxnet-bot avatar Aug 09 '22 07:08 mxnet-bot