mina-sshd icon indicating copy to clipboard operation
mina-sshd copied to clipboard

Implement client-side support of X11 forwarding

Open hstyi opened this issue 8 months ago • 4 comments

Description

Currently, SshClient does not support X11 forwarding, but SshServer seems to.

Motivation

X11 forwarding

Alternatives considered

No response

Additional context

No response

hstyi avatar Mar 29 '25 13:03 hstyi

What exactly do you mean? X11 forwarding from a server to a client should work (client opens an interactive session at the server, then requests X11 forwarding, the server then opens an X11 channel). X11 forwarding from a client to a server should never be allowed.

X11 forwarding is a feature of interactive sessions, but clients should never allow the server to open an interactive session per RFC 4254, section 6.1.

tomaswolf avatar Mar 29 '25 13:03 tomaswolf

Hi, @tomaswolf

I can enable X11 forwarding via JSch like this: X11Forwarding#L47

But how can I do something similar with mina-sshd's SshClient?

hstyi avatar Mar 29 '25 13:03 hstyi

Hi, @tomaswolf

I can enable X11 forwarding via JSch like this: X11Forwarding#L47

But how can I do something similar with mina-sshd's SshClient?

Hi, @tomaswolf

In the future, are there plans to support it?

hstyi avatar Mar 31 '25 01:03 hstyi

Looks like this was never implemented.

PRs welcome. As I don't use this feature myself, investing time to implement it myself is not exactly among my top priorities.

tomaswolf avatar Mar 31 '25 06:03 tomaswolf

兄弟,你是我的神,这就是我一直在找的x11实现,我已经集成了,很好用

oyzh1994 avatar Jul 03 '25 01:07 oyzh1994

兄弟,你是我的神,这就是我一直在找的x11实现,我已经集成了,很好用

Hahaha, initially I wanted to integrate X11 into Termora, but I couldn't find a corresponding implementation, so I developed one myself.

#716 This is just a simple implementation; the complete X11 standard is very complex.

hstyi avatar Jul 03 '25 01:07 hstyi

兄弟你很棒,你的产品我也用了,等会给你提点issue

oyzh1994 avatar Jul 03 '25 01:07 oyzh1994