maven-wrapper icon indicating copy to clipboard operation
maven-wrapper copied to clipboard

[MWRAPPER-108] - only-mvnw add error checking when download or unpacking fails

Open selckin opened this issue 2 years ago • 1 comments

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles, where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

selckin avatar Apr 20 '23 09:04 selckin

I just ran into the same problem while testing out the wrapper and mvnd I didn't set the version correctly I had a silent death. This patch seemed to work fine and produced a reasonable error:

mvnw: Failed to fetch https://archive.apache.org/dist/maven/mvnd/1.0-m8/maven-mvnd-1.0-m8-darwin-aarch64.zip

(My version should have been 1.0-m8-m39)

@selckin I know this has been sitting a while, but do you want rebase? (I would have done it but I didn't want to push changes to your master branch)

bdemers avatar Mar 20 '24 18:03 bdemers

Superseded by https://github.com/apache/maven-wrapper/pull/130

cstamas avatar Apr 17 '24 10:04 cstamas

Resolve #308

jira-importer avatar Jun 14 '25 09:06 jira-importer

Resolve #308

jira-importer avatar Jun 14 '25 09:06 jira-importer