maven-wrapper icon indicating copy to clipboard operation
maven-wrapper copied to clipboard

[MWRAPPER-92] Use https in license links of generated files

Open jira-importer opened this issue 2 years ago • 3 comments

Michael Keppler opened MWRAPPER-92 and commented

The generated scripts mvnw and mvnw.cmd contain links to the Apache license texts. Please make them use https instead of http.

https is already used for the same links in other generated files, like maven-wrapper.properties (and should generally be the default nowadays).

Found because we monitor our own repositories with https://github.com/spring-io/nohttp


Affects: 3.1.1

Issue Links:

  • MWRAPPER-66 maven-wrapper.properties - incorrect header reported by rat plugin

  • LEGAL-265 What are the valid URLs for LICENSE-2.0 at apache.org?

jira-importer avatar Jan 24 '23 09:01 jira-importer

Michael Osipov commented

There is no consent whether this is OK from ASF's point of view because this is a change in license and the license needs to be retained 1:1. It not only applies to this subproject, but all of them.

jira-importer avatar Jan 24 '23 10:01 jira-importer

Damiano Albani commented

Speaking of license file/header, does it make sense to add this header at the top of maven-wrapper.properties when letting Maven Wrapper generate it with mvn wrapper:wrapper?

I mean, it's obvious that license applies to the scripts themselves, but to the configuration file as well??

jira-importer avatar Mar 14 '23 11:03 jira-importer

Lars Bruun-Hansen commented

Damiano Albani (OT) You are right. It doesn't make sense for that header. I've created MWRAPPER-158 to address this.

jira-importer avatar Jan 31 '25 17:01 jira-importer