maven-wrapper icon indicating copy to clipboard operation
maven-wrapper copied to clipboard

[MWRAPPER-57] Make sure that Maven Wrapper created with distribution type set to script won't fail on Unix machines

Open jira-importer opened this issue 3 years ago • 1 comments

Adam Gabrys opened MWRAPPER-57 and commented

When the Maven wrapper:wrapper goal is executed with the -Dtype=script parameter the maven-wrapper.jar and MavenWrapperDownloader.java files are not created. The problem is that the mvnw.cmd script guarantees that the Maven distribution will be downloaded. However, the mvnw script fails when the curl and wget binaries are not installed. It may cause potential issues like "works on my PC, but fails on the CI system". The documentation doesn't Inform the users about that fact.

I see a few possibilities to handle it:

  1. remove the script option, then the people use bin or source. The source option generates the required MavenWrapperDownloader.java file
  2. extend the script documentation with a warning that it may fail
  3. generate different scripts depending on the chosen option - when script is not

No further details from MWRAPPER-57

jira-importer avatar Feb 27 '22 13:02 jira-importer

Slawomir Jaranowski commented

Another proposition MWRAPPER-59 - inline MavenWrapperDownloader.java into mvnw script.

jira-importer avatar Oct 04 '22 20:10 jira-importer