maven-wrapper
maven-wrapper copied to clipboard
[MWRAPPER-158] Remove incorrect license header
The "This code is licensed to ASF" license header on the generated ./mvn/wrapper/maven-wrapper.properties file does not make sense. The file is the user's, not ASF's. It is generated as a convenience for the user.
The file is logically part of the user's own code. We don't know what license that has so adding a license header is bound to be wrong. Therefore removed completely.
I'm guessing the code comes from a time when the Plugin was only (meant to be) used internally in the Apache Maven project. Then it would make sense.
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x ] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like
[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMWRAPPER-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (
mvn -Prun-its clean verify).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
-
[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
-
[ ] In any other case, please file an Apache Individual Contributor License Agreement.
CI pipeline currently blocked by MWRAPPER-159
I don't understand why the test failed. I've never seen this check before:
Run echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >> $GITHUB_PATH
/home/runner/work/maven-wrapper/maven-wrapper/maven-wrapper-distribution/src/resources/mvnw:244:12: note: Double quote to prevent globbing and word splitting. [SC2086]
/home/runner/work/maven-wrapper/maven-wrapper/maven-wrapper-distribution/src/resources/mvnw:246:12: note: Double quote to prevent globbing and word splitting. [SC2086]
/home/runner/work/maven-wrapper/maven-wrapper/maven-wrapper-distribution/src/resources/mvnw:252:12: note: Double quote to prevent globbing and word splitting. [SC2086]
/home/runner/work/maven-wrapper/maven-wrapper/maven-wrapper-distribution/src/resources/mvnw:254:12: note: Double quote to prevent globbing and word splitting. [SC2086]
Resolve #323
Resolve #323
Is that true? .mvn/wrapper/maven-wrapper.properties would ont normally be part fo the user's project. It's maven configuration and would not be checked into the source repo.
It's not true. A lot of projects do add the wrapper configuration in the source tree.
CI pipeline currently blocked by MWRAPPER-159
I think rebasing on current master should work. Can you do that @lbruun ?
I think rebasing on current master should work. Can you do that @lbruun ?
Done!
@gnodet Please assign appropriate label to PR according to the type of change.