maven-wrapper
maven-wrapper copied to clipboard
[MWRAPPER-147] mvnw.cmd fails to launch maven if username contains space
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like
[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMWRAPPER-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ X Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (
mvn -Prun-its clean verify).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
-
[X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
-
[X] In any other case, please file an Apache Individual Contributor License Agreement.
Addresses https://issues.apache.org/jira/browse/MWRAPPER-147
Executing mvnw on Windows where the user name contains space results mvnw failing to launch Maven:
> mvnw
'C:\Users\John' is not recognized as an internal or external command,
operable program or batch file.
Cannot start maven from wrapper
This is a big annoyance esp. for first time users of Maven wrapper who have no clue whats going on.
@michael-o please take a look
@slawekjaranowski can you please have a look?
I don't use windows so can not confirm ... but looks ok
Resolve #295
Resolve #322
Resolve #322
Resolve #295