[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode

[bdemers]

The only-script mode doesn't use the wrapper distribution, this property is now only added to the maven-wrapper.properties file when other types are used.

Following this checklist to help us incorporate your contribution quickly and easily:

• [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• [x] Each commit in the pull request should have a meaningful subject line and body.
• [x] Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles, where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [ ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [ ] In any other case, please file an Apache Individual Contributor License Agreement.

[jira-importer]

Resolve #291

[jira-importer]

Resolve #291

[cstamas]

Original issue that added version: https://issues.apache.org/jira/browse/MWRAPPER-134

So, the intent of the version in the properties file was in fact to ease various automations to detect, and maybe suggest an upgrade for wrapper itself. We are now breaking automations for the second time...

Hence, this PR is wrong. And sorry for being late to the party.

[GreyTeardrop]

I'm in the same boat as @cstamas - only discovered this change when Renovate created an upgrade PR for Maven Wrapper to version 3.3.3 which removes the wrapperVersion property. If that PR gets merged, there won't be an easy way to get another update PR without a manual change. Please, consider rolling back this change…

[breun]

For update automation tools need a reliable way to determine the current version of Maven Wrapper. The wrapperVersion property was a way, although admittedly flawed, because I encounter a lot of projects with wrapperVersion bumped manually, but the mvnw* scripts from a much older version, because they were not updated along with the property.

I saw that Renovate plans to determine the Maven Wrapper version based on a regex check on the scripts themselves (https://github.com/renovatebot/renovate/pull/37779), which should be more reliable than reading wrapperVersion, as long as the format of that comment line it’s parsed from doesn’t change, so it’s still a fragile method.

Could Maven Wrapper provide its version in a more robust (machine-readable) way?

[slawekjaranowski]

@breun please comments in open linked issue

[breun]

@breun please comments in open linked issue

Ok, comment reposted here: https://github.com/apache/maven-wrapper/issues/364#issuecomment-3244006409