maven-surefire icon indicating copy to clipboard operation
maven-surefire copied to clipboard

Published 20 hours ago • verified publisher icon apache

[SUREFIRE-2298] fix xml output with junit 5 nested classes

Open olamy opened this issue 7 months ago • 3 comments
trafficstars

Signed-off-by: Olivier Lamy [email protected]

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles, where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

olamy avatar Apr 04 '25 09:04 olamy

Hi @olamy

you might be able to see progress there https://github.com/apache/maven-surefire/pull/828

But... is there any?

pzygielo avatar May 18 '25 12:05 pzygielo

Hi @olamy

you might be able to see progress there #828

But... is there any?

yup sorry been busy with other stuff.

I'm thinking of possible quick fix which is something more dynamic here https://github.com/apache/maven-surefire/pull/815/files#diff-38e379eb63d7dcd2deb45902b4a494517e4ce54c29913bcf74e7d9243ebb7011R2077

Switching this flag may fix the current issue

olamy avatar May 18 '25 23:05 olamy

Hello everyone, is there an ETA for this fix?

JanMosigItemis avatar Jun 18 '25 10:06 JanMosigItemis

Resolve #2601

jira-importer avatar Jul 04 '25 05:07 jira-importer

I have actually reverted the change (well make this happening only for parallel execution) But even if test number is fine but even with 3.5.2 or even now, generated XML files are/were not correct (there are 3 instead of 2 with the added test with this PR).

olamy avatar Jul 23 '25 06:07 olamy

Sorry for the delay, winter here, so finally back on this. Some progress. Last changes should have fixed the problem, but I need to check what else I just broke :)

olamy avatar Jul 23 '25 10:07 olamy

Thanks for the time and effort you're putting into this!

Is it worth including a test case that specifically targets a Cucumber BDD test case to verify if https://github.com/cucumber/cucumber-jvm/issues/2984 is covered by the fix, once working?

ascopes avatar Aug 28 '25 13:08 ascopes

Oh yeah. we might be finally good now :) it took a while but finally managed to work on this. Sorry for delay

olamy avatar Sep 04 '25 06:09 olamy

The faulty m-sf-p ran cucumber tests fine, but didn't produce expected summary.

I see cucumber test was added, but I can't see its build output to be verified for expected result. Does the new test fail without other changes in this PR? Or would it pass then (with 3.9.3) just like now (hence not providing new check)?

pzygielo avatar Sep 04 '25 10:09 pzygielo

The faulty m-sf-p ran cucumber tests fine, but didn't produce expected summary.

I see cucumber test was added, but I can't see its build output to be verified for expected result. Does the new test fail without other changes in this PR? Or would it pass then (with 3.9.3) just like now (hence not providing new check)?

build output not verified? you sure?

https://github.com/apache/maven-surefire/pull/828/files#diff-b64af33c9a98c2d43c52cfca7f3bb89af9a833feae8489c0738560350c4592caR55

olamy avatar Sep 04 '25 10:09 olamy

The faulty m-sf-p ran cucumber tests fine, but didn't produce expected summary. I see cucumber test was added, but I can't see its build output to be verified for expected result. Does the new test fail without other changes in this PR? Or would it pass then (with 3.9.3) just like now (hence not providing new check)?

build output not verified?

https://github.com/apache/maven-surefire/pull/828/files#diff-b64af33c9a98c2d43c52cfca7f3bb89af9a833feae8489c0738560350c4592caR55

Thanks!

you sure?

No. I said I could not see this. And now I do.

pzygielo avatar Sep 04 '25 10:09 pzygielo

@olamy The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to.

github-actions[bot] avatar Sep 04 '25 22:09 github-actions[bot]

When is the new release coming out? I have a PR open that I want to merge once the release is out: https://github.com/jesperancinha/jeorg-spring-test-drives/pull/890

jesperancinha avatar Sep 11 '25 16:09 jesperancinha

When is the new release coming out? I have a PR open that I want to merge once the release is out: jesperancinha/jeorg-spring-test-drives#890

will be soon: https://lists.apache.org/thread/r905v9hrvz34f5t3vzbvnd64fbvpb1no

slawekjaranowski avatar Sep 11 '25 20:09 slawekjaranowski