maven-shade-plugin icon indicating copy to clipboard operation
maven-shade-plugin copied to clipboard

[MSHADE-196] Must not attempt to unzip unfamiliar dependency type

Open jira-importer opened this issue 10 years ago • 1 comments

Markus Karg opened MSHADE-196 and commented

When adding dependencies to rather unconventional package types, like "dll" or "pdf", we noticed that the share plugin by default tries to unzip them. This is weird, as obviously this attempt will fail in almost any case. A user is forced to add explicit exceptions, which is tedious, error prone, and breaks CoC.

The solution is rather obvious: The shade plugin must only unzip those package types which it is familiar with. This namely is e. g. JAR, ZIP, BZIP, GZIP etc. but certainly not anything unknown.

The result of this change will be a simplification of the pom.xml, and shade plugin's behaviour will be more like a user expects it to work: Don't touch unkown stuff!


Affects: 2.3

jira-importer avatar Jun 25 '15 08:06 jira-importer

Elliotte Rusty Harold commented

seems right

jira-importer avatar Dec 18 '19 11:12 jira-importer