maven-shade-plugin icon indicating copy to clipboard operation
maven-shade-plugin copied to clipboard

[MSHADE-160] change default location of dependency-reduced-pom.xml

Open jira-importer opened this issue 12 years ago • 2 comments

Gabriele Catania opened MSHADE-160 and commented

The current defaults of the plugin place the dependency reduced pom alongside the pom.xml as a sibling file.

Given that it's a generated file, wouldn't it be best to place it by default inside the target directory?

either something like this:

<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation>

or, even better (to conform with conventions from other plugins):

<dependencyReducedPomLocation>${project.build.directory}/generated/shade/dependency-reduced-pom.xml</dependencyReducedPomLocation>

Affects: 2.2

Issue Links:

  • MSHADE-124 Need better plan for getting dependency-reduced-pom.xml out of basedir ("is blocked by")
  • MSHADE-187 Change location of the dependency reduced pom ("is duplicated by")
  • MSHADE-170 Outstanding questions about MSHADE-124

3 votes, 7 watchers

jira-importer avatar Nov 29 '13 09:11 jira-importer

Robert Scholte commented

Ideally the MavenProject should also be updated with respect to the new pom. For a long time the basedir was set to the directory of the pom-file. Since Maven 3.2.4 there's a method called setPomFile which only changes the pomFile and not the basedir, which is probably required in this case.

jira-importer avatar Jan 18 '17 14:01 jira-importer

James Z.M. Gao commented

as Robert Scholte suggest, a new pr can solve MSHADE-124, then this issue can be solved finally

jira-importer avatar Apr 05 '22 06:04 jira-importer