maven-shade-plugin icon indicating copy to clipboard operation
maven-shade-plugin copied to clipboard

[MSHADE-156] - Allow non relocating string literals

Open andclt opened this issue 10 months ago • 3 comments

Notes

Jira issue: MSHADE-156

Add the option to skip relocating string literals. Currently this is not possible and the only available solution is to create a "fake" relocation pattern to prevent such behavior, example. This change adds a new property skipStringLiteral which still relocates the prefix instances but not the string literals.

Testing

mvn clean verify

Results:
[INFO] Tests run: 72, Failures: 0, Errors: 0, Skipped: 0

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles, where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

andclt avatar Feb 03 '25 00:02 andclt

Seems this also addresses MSHADE-153.

Goooler avatar Apr 16 '25 00:04 Goooler

Resolve #518

jira-importer avatar Jun 14 '25 16:06 jira-importer

Resolve #518

jira-importer avatar Jun 14 '25 17:06 jira-importer

can you merge with master?

elharo avatar Sep 11 '25 12:09 elharo