[MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths

[roadSurfer]

This reverts the change from MENFORCER-364 as this led to a regressions with symbolic links.

The fundamental issue is that there is no clean way to deal with case-sensitivity as OSs can have multuple filesystems mounted that follow different rules. Thus the simple file.exists() is, despite the limitations, probably best. Those requiring more stringent checks writing their own handling.

Following this checklist to help us incorporate your contribution quickly and easily:

• [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• [x] Each commit in the pull request should have a meaningful subject line and body.
• [x] Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles, where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [ ] In any other case, please file an Apache Individual Contributor License Agreement.

[slawekjaranowski]

Ok, the simple file.exists() should be enough in normal usage ...

I only think - if we don't break and special cases ... but agree more complicated check should be done optionally or by next rule

By the way we can mention in documentation a way how file existence is checked to be clear.

[roadSurfer]

I have added some words to the affected documentation on case-sensitivity, as well as some explic testing of symbolic links.

[Torbjorn-Svensson]

Are all the white space changes in the .md files intended? As far as I know, some of the trailing white spaces are needed in order to not join the lines.

[roadSurfer]

No, they are not intended. That will be my IDE doing its own thing, I'll use a different editor and update.

On Mon, 27 Nov 2023 at 15:20, Torbjorn-Svensson @.***> wrote:

Are all the white space changes in the .md files intended? As far as I know, some of the trailing white spaces are needed in order to not join the lines.

— Reply to this email directly, view it on GitHub https://github.com/apache/maven-enforcer/pull/297#issuecomment-1828041274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJHMQU65AH2DOVYZVDQKTUTYGSVUVAVCNFSM6AAAAAA7ZJWO7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGA2DCMRXGQ . You are receiving this because you authored the thread.Message ID: @.***>

[roadSurfer]

That should be the whitepsace issues sorted. I also generated the site locally and it appeared OK to me.

[jira-importer]

Resolve #501

[jira-importer]

Resolve #501

[github-actions[bot]]

This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.

[github-actions[bot]]

This pull request has been closed because no response was received within 90 days.