maven-deploy-plugin icon indicating copy to clipboard operation
maven-deploy-plugin copied to clipboard

[MDEPLOY-311] Pass on 'packaging' when creating artifact to upload

Open sratz opened this issue 2 years ago • 3 comments

Fixes a regression introduced in 16541da43c51237cf7183c4500a576108ad946b8 [MDEPLOY-296] which caused the -Dpackaging property to be ignored when uploading the artifact. Instead, the packaging type during upload was always derived from the file name.


Following this checklist to help us incorporate your contribution quickly and easily:

  • [X] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [X] Each commit in the pull request should have a meaningful subject line and body.
  • [X] Format the pull request title like [MDEPLOY-XXX] - Fixes bug in ApproximateQuantiles, where you replace MDEPLOY-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [X] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [X] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

sratz avatar Jul 03 '23 09:07 sratz

Ping - any feedback on this PR / issue?

sratz avatar Aug 30 '23 11:08 sratz

your assumptions is wrong, generally packaging may be different then deployed file extension, eg packaging ejb has extension jar

slawekjaranowski avatar Aug 30 '23 21:08 slawekjaranowski

Something is fishy about this PR, but I think I understand the intent.... is the generated POM/packaging wrong?

cstamas avatar Oct 23 '23 23:10 cstamas

Superded by https://github.com/apache/maven-deploy-plugin/pull/71

cstamas avatar Aug 14 '24 13:08 cstamas

Awesome, thanks!

sratz avatar Aug 15 '24 15:08 sratz

Resolve #576

jira-importer avatar Apr 02 '25 07:04 jira-importer