maven-dependency-plugin icon indicating copy to clipboard operation
maven-dependency-plugin copied to clipboard

Fix [MDEP-931] Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses

Open Ndacyayisenga-droid opened this issue 6 months ago • 2 comments

Following this checklist to help us incorporate your contribution quickly and easily:

Fixes https://issues.apache.org/jira/browse/MDEP-931

cc @elharo

  • [ ] Your pull request should address just one issue, without pulling in other changes.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
  • [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • [x] Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

Ndacyayisenga-droid avatar May 20 '25 13:05 Ndacyayisenga-droid

CI failing on a known flaky test:

Error:  Failures: 
Error:    TestUnpackMojo.testUnpackOverWriteIfNewer:513 unpackedFile '/var/folders/tp/bfmjfn9s0hd59bm9z80j3mgm0000gn/T/unpack2709761897097392486/outputDirectory/testGroupId-snapshot-2.0-SNAPSHOT-null-jar.txt' lastModified() == 1748599196000: should be different. Actual: 1748599196000
[INFO] 

elharo avatar May 30 '25 17:05 elharo

Resolve #1439

jira-importer avatar Jun 18 '25 08:06 jira-importer

@elharo I droped all the stringwiters and wrote straight onto the writer

Ndacyayisenga-droid avatar Jun 30 '25 13:06 Ndacyayisenga-droid

@slawekjaranowski Please assign appropriate label to PR according to the type of change.

github-actions[bot] avatar Aug 10 '25 13:08 github-actions[bot]