maven-dependency-plugin icon indicating copy to clipboard operation
maven-dependency-plugin copied to clipboard

Published 20 hours ago • verified publisher icon apache

[MDEP-960] Repair silent logging

Open elharo opened this issue 1 year ago • 3 comments

This test could never fail

elharo avatar Oct 17 '24 11:10 elharo

Yes, I'm not sure why this was done like this in the first place. This has been around since 2.0 so who knows? I am confident the way it was done is buggy, so this tries to repair as much of it as I easily could. I noticed because the tests mixed up two different silent log classes. Someone wasn't following test first practices when they wrote this.

If we're comfortable with some incompatibility, then we could mke the silent parameter and associated methods noops.

elharo avatar Oct 22 '24 12:10 elharo

Yes, I'm not sure why this was done like this in the first place. This has been around since 2.0 so who knows? I am confident the way it was done is buggy, so this tries to repair as much of it as I easily could. I noticed because the tests mixed up two different silent log classes. Someone wasn't following test first practices when they wrote this.

If we're comfortable with some incompatibility, then we could mke the silent parameter and associated methods noops.

Maybe we should deprecate for removal in 4?

michael-o avatar Oct 22 '24 14:10 michael-o

OK, deprecated

elharo avatar Oct 22 '24 19:10 elharo

Ping

elharo avatar Nov 07 '24 20:11 elharo

Resolve #1455

jira-importer avatar Jun 18 '25 08:06 jira-importer