maven-dependency-plugin icon indicating copy to clipboard operation
maven-dependency-plugin copied to clipboard

Published 20 hours ago • verified publisher icon apache

[MDEP-568] go offline filter

Open bmarwell opened this issue 4 years ago • 1 comments

Following this checklist to help us incorporate your contribution quickly and easily:

  • [X] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [X] Each commit in the pull request should have a meaningful subject line and body.
  • [X] Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles, where you replace MDEP-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [X] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [X] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

bmarwell avatar Jun 01 '21 10:06 bmarwell

@elharo can you please look over this PR again?

bmarwell avatar Aug 13 '21 11:08 bmarwell

Would really appreciate this being re-looked at and merged, it causes us problems when caching dependencies in Gitlab if these filters don't actually work.

Happy to provide input/coding

@elharo @bmarwell

TimKnight-DWP avatar Oct 28 '22 08:10 TimKnight-DWP

@elharo I fixed in https://github.com/apache/maven-dependency-plugin/pull/258 most of your questions. Also, I resolved the conflicts with master.

About the overall aproach, I was never able to fully understand what is the problem with this one. @bmarwell could you please help with this?

antoniolucasnobar avatar Nov 06 '22 04:11 antoniolucasnobar

Is this going to be merged anytime soon?

It would be really helpful to install and cache dependencies prior to mvn package.

jshbrntt avatar Aug 09 '23 20:08 jshbrntt

This is old. If interested, please do a new PR. I'll leave the branch for a while.

bmarwell avatar Nov 04 '23 11:11 bmarwell