maven-compiler-plugin icon indicating copy to clipboard operation
maven-compiler-plugin copied to clipboard

[MCOMPILER-397] Use relative paths in jpms.args to make the builds reproducible

Open ebourg opened this issue 2 years ago • 6 comments

PR for https://issues.apache.org/jira/browse/MCOMPILER-397

ebourg avatar Jun 17 '23 12:06 ebourg

This is incomplete, the path separators have to be normalized too.

ebourg avatar Jun 17 '23 14:06 ebourg

Done on a clone of the master branch (not yet merged). The fix in this pull request could not be applied on master, but could be applied on the 3.x branch. Should we redirect the target branch to 3.x, or close as "fixed" (after merge of aa4509b94629b6ab136fb763992ed055793f2421)?

desruisseaux avatar Mar 15 '25 14:03 desruisseaux

We can change target branch by edit PR ...

slawekjaranowski avatar Mar 15 '25 14:03 slawekjaranowski

@ebourg can you look at commit: https://github.com/apache/maven-compiler-plugin/commit/aa4509b94629b6ab136fb763992ed055793f2421 I don't see if was or not merged

but look like better implementation

slawekjaranowski avatar Jun 07 '25 10:06 slawekjaranowski

ok, was merged with https://github.com/apache/maven-compiler-plugin/pull/320 - one big PR 😄

slawekjaranowski avatar Jun 07 '25 10:06 slawekjaranowski

Resolve #626

jira-importer avatar Jun 16 '25 05:06 jira-importer

This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.

github-actions[bot] avatar Aug 20 '25 03:08 github-actions[bot]