Checkstyle 10.x

[michael-o]

Following this checklist to help us incorporate your contribution quickly and easily:

• [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• [ ] Each commit in the pull request should have a meaningful subject line and body.
• [ ] Format the pull request title like [MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles, where you replace MCHECKSTYLE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [ ] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [ ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [ ] In any other case, please file an Apache Individual Contributor License Agreement.

[romani]

In CI I see Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:4.0.0-M15:site (default-site) on project MCHECKSTYLE-357: Error generating maven-checkstyle-plugin:3.4.1-SNAPSHOT:checkstyle report: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module MissingDeprecated - Property 'skipNoJavadoc' does not exist, please check the documentation -> [Help 1]

https://checkstyle.org/checks/annotation/missingdeprecated.html#Properties

Property was removed in scope of https://github.com/checkstyle/checkstyle/commit/2f8bcacc1e22b2ad0e249a0f942f799e47f23d0a#diff-e443a0018a3dae545ad69f558f511366d5d8d9ea032edc26ea719d24bbb0cdedL61 That was breaking changes https://github.com/checkstyle/checkstyle/issues/4983 there is Migration Notes section in issue.

[michael-o]

In CI I see Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:4.0.0-M15:site (default-site) on project MCHECKSTYLE-357: Error generating maven-checkstyle-plugin:3.4.1-SNAPSHOT:checkstyle report: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module MissingDeprecated - Property 'skipNoJavadoc' does not exist, please check the documentation -> [Help 1]

https://checkstyle.org/checks/annotation/missingdeprecated.html#Properties

Property was removed in scope of checkstyle/checkstyle@2f8bcac#diff-e443a0018a3dae545ad69f558f511366d5d8d9ea032edc26ea719d24bbb0cdedL61 That was breaking changes checkstyle/checkstyle#4983 there is Migration Notes section in issue.

Thanks, I already found both yesterday, but honestly, it is not clear to me whether there is a replacement and which because violateExecutionOnNonTightHtml is not the same. Obviously this: https://github.com/hazendaz/maven-checkstyle-plugin/commit/714c075158b70f085bd16722b460bc850e897059?

[romani]

Obviously this: https://github.com/hazendaz/maven-checkstyle-plugin/commit/714c075158b70f085bd16722b460bc850e897059?

yes

[motlin]

I'm using this locally by running

<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.4.1-SNAPSHOT</version>

and it's working great for me. Any chance of getting it released? I'd love to start using SARIF from our GitHub workflows.

[michael-o]

@romani This runs locally for me. Hope that CI will as well.

[motlin]

Checking again whether this might be released soon. I'm considering releasing this under a different groupID so I can start using it.

[michael-o]

Checking again whether this might be released soon. I'm considering releasing this under a different groupID so I can start using it.

There is nothing to release since Checkstyle 10.x is now upwards-compatible with the current plugin version.

[michael-o]

Closing as a PoC.