[MBUILDCACHE-87] - Checksum should consider plugin dependencies

[reda-alaoui]

Following this checklist to help us incorporate your contribution quickly and easily:

• [X] Make sure there is a MBUILDCACHE JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• [X] Each commit in the pull request should have a meaningful subject line and body.
• [X] Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles, where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [X] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [X] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [ ] In any other case, please file an Apache Individual Contributor License Agreement.

[AlexanderAshitkin]

In addition to the test created, it will be nice to cover the logic with tests more cases:

• External plugin dependency of a snapshot version is also accounted for in the checksum.
• Dependencies present both as a project dependency and a plugin dependency are counted twice (adding a plugin dependency in addition to an existing project dependency changes the checksum) and vice versa

[AlexanderAshitkin]

The increased entropy could be a potential vector of regression. Though the feature looks legit and should be on by default, there should be a way to turn it off if it doesn't work as expected. Please add a configuration flag to turn it off. Ideally, it should be a per-plugin flag.

[reda-alaoui]

Oups, I forgot to add logs.

[reda-alaoui]

@AlexanderAshitkin can you take a look again?

[reda-alaoui]

@AlexanderAshitkin Could you take a look? :)

[AlexanderAshitkin]

@AlexanderAshitkin Could you take a look? :)

Hi, It looks good to me, so I approve. However, I kindly ask you to find and implement the test requested above. If it is not in your plans, I will create a ticket to improve the coverage.

[AlexanderAshitkin]

@olamy @gnodet @maximilian-novikov Hey Folks, could you please look at this PR?

[reda-alaoui]

Can I do something more to get this merged?