maven-archetype icon indicating copy to clipboard operation
maven-archetype copied to clipboard

[ARCHETYPE-617] Files in a folder with a file that has no extension are not filtered

Open jira-importer opened this issue 4 years ago • 2 comments

Thomas Pischke opened ARCHETYPE-617 and commented

When using create-from-project, the filtering works but the filtered file is later overwritten with the original unfiltered content. The overwrite occurs due to an overly broad fileset (*/) created due to the presence of a file with no extension in the folder.

We rely on the secondLevelResourceDirectory structure to include the directory.

Working on a PR.

Also broken in 3.2.1-SNAPSHOT

Example file structure that exhibits the bug:

  • build
    • docker *** Dockerfile *** should-be-filtered-but-is-not.yaml

Affects: 3.2.0

Issue Links:

  • ARCHETYPE-548 Resource files without extensions are not included in archetype

jira-importer avatar Jun 17 '21 13:06 jira-importer

Thomas Pischke commented

This would also be fixed by the PR in ARCHETYPE-548, but that issue is marked as closed.

jira-importer avatar Jun 22 '21 13:06 jira-importer

Thomas Pischke commented

We have a quick and dirty local patch to fix this problem, but still need to clean it up for submission. Might end up looking very similar to https://github.com/apache/maven-archetype/pull/32, which seems like a reasonable fix.

jira-importer avatar Jun 22 '21 13:06 jira-importer