maven-apache-parent icon indicating copy to clipboard operation
maven-apache-parent copied to clipboard

[MPOM-218] consider impact of maven-remote-resources-plugin in plugins not pluginManagement

Open jira-importer opened this issue 6 years ago • 4 comments

Adrian Cole opened MPOM-218 and commented

While maven-remote-resources-plugin in plugins, it is difficult to work with vs if it were in pluginManagement. For example, the parent pom can spit out a distracting empty DEPENDENCIES file, which ends up by default in the source distribution.

I've noticed multiple projects (ex dubbo, edgent) creating separate distribution modules which on one hand works around this issue, but on the other is a source of maintenance.

I'd ask to consider using pluginManagement instead, or possibly having the ability to not create a DEPENDENCIES file when there are none, which would also solve the problem. Maybe there's also another way to strip this out with an assembly, but I've failed to figure this out.


Affects: ASF-16, ASF-24

Issue Links:

  • MPOM-134 Add profile to use a different resource bundle for incubator projects

Remote Links:

2 votes, 4 watchers

jira-importer avatar Feb 19 '19 10:02 jira-importer

Christopher Tubbs commented

In Accumulo, we just just provide a basic "DEPENDENCIES" file. The plugin doesn't clobber the one that already exists: https://github.com/apache/accumulo/blob/rel/2.0.0/DEPENDENCIES

jira-importer avatar Aug 05 '19 23:08 jira-importer

Herve Boutemy commented

yes, there is an execution that has been defined intentionally 12 years ago to run: here is the code

<!-- We want to package up license resources in the JARs produced -->
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-remote-resources-plugin</artifactId>
  <executions>
    <execution>
      <id>process-resource-bundles</id>
      <goals>
        <goal>process</goal>
      </goals>
      <configuration>
        <resourceBundles>
          <resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle>
        </resourceBundles>
      </configuration>
    </execution>
  </executions>
</plugin>

using the Apache jar resource bundle https://maven.apache.org/apache-resource-bundles/index.html#jar-resource-bundle-and-incubator-disclaimer-resource-bundle

it was added in https://github.com/apache/maven-apache-parent/commit/b6d76ce21b88c46a95e4c851d9da47013972152b

I must admit I don't really know the content, what would be the consequence of simply removing that config, or if we can make it easily configurable

jira-importer avatar Dec 26 '21 22:12 jira-importer

Herve Boutemy commented

it looks a little bit like MPOM-134

jira-importer avatar Dec 26 '21 22:12 jira-importer

Slawomir Jaranowski commented

Project issues moved to GitHub, please copy to it.

jira-importer avatar Apr 21 '24 08:04 jira-importer